fix incorrect circle color in Tournament Player Details#2845
Merged
veloce merged 2 commits intolichess-org:mainfrom Mar 27, 2026
Merged
fix incorrect circle color in Tournament Player Details#2845veloce merged 2 commits intolichess-org:mainfrom
veloce merged 2 commits intolichess-org:mainfrom
Conversation
veloce
reviewed
Mar 26, 2026
| child: Icon(LichessIcons.body_cut, size: 20), | ||
| ), | ||
| Icon(pairing.color == Side.white ? Icons.circle_outlined : Icons.circle, size: 20), | ||
| Icon(pairing.color == Side.white ? Icons.circle : Icons.circle_outlined, size: 20), |
Contributor
There was a problem hiding this comment.
I believe it depends on the background theme as well (dark vs light). Does it? In that case we should use an helper.
Collaborator
Author
There was a problem hiding this comment.
Ah yes it does, good catch
HaonRekcef
commented
Mar 26, 2026
| child: Center(child: SideIndicator(side: color, size: 15)), | ||
| ), | ||
| if (showTCIcon) SizedBox(width: 12, child: Icon(fideTC.icon, size: 15)), | ||
| if (showTCIcon) Icon(fideTC.icon, size: 15), |
Collaborator
Author
There was a problem hiding this comment.
unrelated change, but I don't think we should wrap the Icon with Size 15 in a SizedBox with lesser size, so I simply removed it as I don't see a reason for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The color of the circle indicating the color the player had in the game was swapped. Reported here: https://lichess.org/forum/community-blog-discussions/ublog-VGPcQtN3?page=5#DPksKbS9
Created a new side indicator widget and also used it in the
broadcast_player_results_screen.dart.dark mode:
light mode: